Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Error fix #678

Merged
merged 2 commits into from
Jul 15, 2024
Merged

test: Error fix #678

merged 2 commits into from
Jul 15, 2024

Conversation

henrywang
Copy link
Contributor

This PR fixed two errors:

  1. do not check cachedUpdate.imageDigest in rollback test. The cachedUpdate.imageDigest is always null. We have wget package checking for rollback successful or not.
  2. do not delete image before copy it. Fix "ERROR Pushing image: Export: Copying image: No such image" in integration test.

The cachedUpdate.imageDigest always null
Check wget package not exist for rollback successful

Signed-off-by: Xiaofeng Wang <henrywangxf@me.com>
Fix "ERROR Pushing image: Export: Copying image: No such image"

Signed-off-by: Xiaofeng Wang <henrywangxf@me.com>
@henrywang
Copy link
Contributor Author

Hi @cgwalters, I can't figure out the root cause of integration test failure. I removed do --ignore-errors { podman image rm localhost/bootc o+e>| ignore }, but still has error. Could you please help on this error? Thanks!

Copying local image docker://localhost/bootc to containers-storage:localhost/bootc ...
ERROR Pushing image: Export: Copying image: No such image

@cgwalters
Copy link
Collaborator

I removed do --ignore-errors { podman image rm localhost/bootc o+e>| ignore }, but still has error.

Hmm...yeah, this is one of those downsides of nushell for sure, there are a few IMO obscure/weird syntaxes. (The other one I find strange is error make)

But...this works for me? Hmm...will dig a bit

@cgwalters cgwalters enabled auto-merge July 15, 2024 18:40
@cgwalters cgwalters disabled auto-merge July 15, 2024 18:40
@cgwalters cgwalters merged commit 42fe361 into containers:main Jul 15, 2024
23 of 27 checks passed
@cgwalters
Copy link
Collaborator

But...this works for me? Hmm...will dig a bit

I didn't get to the bottom of this, but if it somehow helps it's fine by me to just delete that line because we'll end up replacing the image anyways.

cgwalters added a commit to cgwalters/bootc that referenced this pull request Nov 5, 2024
README: Update now that it is no longer a daemon
cgwalters added a commit to cgwalters/bootc that referenced this pull request Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants